Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 8, 2025

PR-Codex overview

This PR focuses on enhancing the sendUsageV2Events function in the service-utils package to allow client-side usage reporting by introducing a new UsageV2Source type and modifying the function's parameters and fetch logic.

Detailed summary

  • Added UsageV2Source to the import statement in usageV2.ts.
  • Modified the options parameter in sendUsageV2Events to include source and make serviceKey optional.
  • Updated the fetch URL logic to handle unauthenticated calls to the /client path based on the presence of serviceKey.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 8, 2025 04:23
@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2025

🦋 Changeset detected

Latest commit: f1e9159

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:30am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:30am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:30am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:30am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 4:30am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.77%. Comparing base (fecd3a6) to head (f1e9159).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6207   +/-   ##
=======================================
  Coverage   56.77%   56.77%           
=======================================
  Files        1161     1161           
  Lines       64261    64261           
  Branches     5196     5196           
=======================================
  Hits        36483    36483           
  Misses      27050    27050           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from fecd3a6
packages 54.95% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 3 s (+0.71% 🔺) 3.9 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 5.9 s (-17.56% 🔽) 8.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 329 ms (+12.87% 🔺) 441 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 109 ms (+40.83% 🔺) 119 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 635 ms (-32.04% 🔽) 1.1 s

@arcoraven arcoraven disabled auto-merge February 8, 2025 05:07
@arcoraven arcoraven merged commit cbfe9ec into main Feb 8, 2025
35 checks passed
@arcoraven arcoraven deleted the ph/clientSideUsageV2 branch February 8, 2025 05:08
@joaquim-verges joaquim-verges mentioned this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants